Modernize BufferedWriter creation & prevent file descriptor leaks
Recipe ID
org.openrewrite.staticanalysis.BufferedWriterCreationRecipesArtifact
org.openrewrite.recipe:rewrite-static-analysisThe code new BufferedWriter(new FileWriter(f)) creates a BufferedWriter that does not close the underlying FileWriter when it is closed. This can lead to file descriptor leaks as per CWE-755. Use Files.newBufferedWriter to create a BufferedWriter that closes the underlying file descriptor when it is closed.
Usage
This recipe has no required configuration options. You’ll need the Moderne CLI configured before running the command below.
mod run . --recipe org.openrewrite.staticanalysis.BufferedWriterCreationRecipesIf the recipe isn’t available locally, install it with:
mod config recipes jar install org.openrewrite.recipe:rewrite-static-analysis:2.40.0Definition
This recipe runs the following recipes in order.
- Convert
new BufferedWriter(new FileWriter(File))toFiles.newBufferedWriter(Path)org.openrewrite.staticanalysis.BufferedWriterCreationRecipes$BufferedWriterFromNewFileWriterWithFileArgumentRecipe - Convert
new BufferedWriter(new FileWriter(String))toFiles.newBufferedWriter(Path)org.openrewrite.staticanalysis.BufferedWriterCreationRecipes$BufferedWriterFromNewFileWriterWithStringArgumentRecipe - Convert
new BufferedWriter(new FileWriter(File, boolean))toFiles.newBufferedWriter(Path, StandardOpenOption)org.openrewrite.staticanalysis.BufferedWriterCreationRecipes$BufferedWriterFromNewFileWriterWithFileAndBooleanArgumentsRecipe - Convert
new BufferedWriter(new FileWriter(String, boolean))toFiles.newBufferedWriter(Path, StandardOpenOption)org.openrewrite.staticanalysis.BufferedWriterCreationRecipes$BufferedWriterFromNewFileWriterWithStringAndBooleanArgumentsRecipe
Data tables
Structured output this recipe can produce.
- Source files that had resultsSource files that were modified by the recipe run.
org.openrewrite.table.SourcesFileResults - Source files that had search resultsSearch results that were found during the recipe run.
org.openrewrite.table.SearchResults - Source files that errored on a recipeThe details of all errors produced by a recipe run.
org.openrewrite.table.SourcesFileErrors - Recipe performanceStatistics used in analyzing the performance of recipes.
org.openrewrite.table.RecipeRunStats