Find raw try/catch smells
org.openrewrite.kotlin.functional.FindTryCatchSmells$KtRecipeArtifactio.moderne.recipe:recipes-kotlinSearch-only bundle for try/catch shapes worth reviewing: collapse-to-null and collapse-to-default branches (candidates for runCatching { }.getOrNull() / .getOrDefault(...)), empty catches that lose every detail of the failure, broad catch (Exception) / catch (Throwable) clauses, catches that absorb the exception without logging or rethrowing, e.printStackTrace() calls that should be logger calls, nested try/catch trees, and catch parameters that are bound but never read.
Add to your build
~/.gradle/gradle.properties
codeGenomeUsername=you@example.com
codeGenomeToken=YOUR_DOWNLOAD_TOKEN
build.gradle.kts
plugins {
id("org.openrewrite.rewrite") version("latest.release")
}
rewrite {
activeRecipe("org.openrewrite.kotlin.functional.FindTryCatchSmells$KtRecipe")
}
repositories {
mavenCentral()
maven {
url = uri("https://artifacts.codegenomeproject.org/maven")
credentials {
username = providers.gradleProperty("codeGenomeUsername").get()
password = providers.gradleProperty("codeGenomeToken").get()
}
}
}
dependencies {
rewrite("io.moderne.recipe:recipes-kotlin:0.5.0")
}
Then run
./gradlew rewriteRunUsage
This recipe has no required configuration options. You’ll need the Moderne CLI configured before running the command below.
mod run . --recipe org.openrewrite.kotlin.functional.FindTryCatchSmells$KtRecipeIf the recipe isn’t available locally, install it with:
mod config recipes jar install io.moderne.recipe:recipes-kotlin:RELEASEDefinition
This recipe runs the following recipes in order.
- Find
try { x } catch (e: Exception) { null }patternsorg.openrewrite.kotlin.functional.FindTryCatchReturningNull$KtRecipe - Find
try { x } catch (e: Exception) { default }patternsorg.openrewrite.kotlin.functional.FindTryCatchReturningDefault$KtRecipe - Find empty catch blocks
org.openrewrite.kotlin.functional.FindTryCatchSwallowingException$KtRecipe - Find broad
catch (e: Exception)/catch (e: Throwable)clausesorg.openrewrite.kotlin.functional.FindCatchAllException$KtRecipe - Find non-empty catch blocks that neither log nor rethrow
org.openrewrite.kotlin.functional.FindCatchWithoutLogging$KtRecipe - Find
e.printStackTrace()calls inside a catch blockorg.openrewrite.kotlin.functional.FindPrintStackTraceInCatch$KtRecipe - Find
try { } catch { }nested inside anothertry { } catch { }org.openrewrite.kotlin.functional.FindNestedTryCatch$KtRecipe - Find
catch (e: Exception)clauses whose body never referenceseorg.openrewrite.kotlin.functional.FindCatchBindingUnusedException$KtRecipe
Data tables
Structured output this recipe can produce.
- Source files that had resultsSource files that were modified by the recipe run.
org.openrewrite.table.SourcesFileResults - Source files that had search resultsSearch results that were found during the recipe run.
org.openrewrite.table.SearchResults - Source files that errored on a recipeThe details of all errors produced by a recipe run.
org.openrewrite.table.SourcesFileErrors - Recipe performanceStatistics used in analyzing the performance of recipes.
org.openrewrite.table.RecipeRunStats