Find runCatching { } smells
Recipe ID
org.openrewrite.kotlin.functional.FindRunCatchingSmells$KtRecipeArtifact
io.moderne.recipe:recipes-kotlinSearch-only bundle covering the most common runCatching { } pitfalls: swallowing CancellationException, collapsing failures into null via .getOrNull(), discarding the Result in statement context, log-only handlers that drop the failure on the floor, .onSuccess { } chains with no failure handler, and .getOrThrow() patterns that turn the Result round-trip into pure ceremony.
Usage
This recipe has no required configuration options. You’ll need the Moderne CLI configured before running the command below.
mod run . --recipe org.openrewrite.kotlin.functional.FindRunCatchingSmells$KtRecipeIf the recipe isn’t available locally, install it with:
mod config recipes jar install io.moderne.recipe:recipes-kotlin:0.2.0Definition
This recipe runs the following recipes in order.
- Find
runCatching { }blocks that may swallowCancellationExceptionorg.openrewrite.kotlin.functional.FindRunCatchingSwallowingCancellation$KtRecipe - Find
runCatching { }.getOrNull()chainsorg.openrewrite.kotlin.functional.FindRunCatchingGetOrNullDiscardingError$KtRecipe - Find
runCatching { }calls whose result is discardedorg.openrewrite.kotlin.functional.FindRunCatchingWithoutHandling$KtRecipe - Find
runCatching { }.onFailure { log… }chains with no further handlingorg.openrewrite.kotlin.functional.FindRunCatchingForLogOnly$KtRecipe - Find
runCatching { }.onSuccess { … }chains with no failure handlerorg.openrewrite.kotlin.functional.FindRunCatchingOnSuccessOnly$KtRecipe - Find
.getOrThrow()calls on aResult<T>org.openrewrite.kotlin.functional.FindResultGetOrThrow$KtRecipe
Data tables
Structured output this recipe can produce.
- Source files that had resultsSource files that were modified by the recipe run.
org.openrewrite.table.SourcesFileResults - Source files that had search resultsSearch results that were found during the recipe run.
org.openrewrite.table.SearchResults - Source files that errored on a recipeThe details of all errors produced by a recipe run.
org.openrewrite.table.SourcesFileErrors - Recipe performanceStatistics used in analyzing the performance of recipes.
org.openrewrite.table.RecipeRunStats