Find lambda / functional smells
Recipe ID
org.openrewrite.kotlin.bestpractices.FindLambdaSmells$KtRecipeArtifact
io.moderne.recipe:recipes-kotlinRedundant map { it.toString() } / forEach { it.toString() }, debug-leftover .also { println(it) } / forEach { println(it) }, xs.toList().forEach { } over already-iterable receivers, .also { it.add(...) }-built mutable collections, and forEach { ys.add(it) } (use addAll).
Usage
This recipe has no required configuration options. You’ll need the Moderne CLI configured before running the command below.
mod run . --recipe org.openrewrite.kotlin.bestpractices.FindLambdaSmells$KtRecipeIf the recipe isn’t available locally, install it with:
mod config recipes jar install io.moderne.recipe:recipes-kotlin:0.2.0Definition
This recipe runs the following recipes in order.
- Find
map { it.toString() }/map { x -> x.toString() }patternsorg.openrewrite.kotlin.bestpractices.FindRedundantToStringInMap$KtRecipe - Find
forEach { it.toString() }patternsorg.openrewrite.kotlin.bestpractices.FindRedundantToStringInForEach$KtRecipe - Find
.also { println(it) }debug patternsorg.openrewrite.kotlin.bestpractices.FindAlsoPrintln$KtRecipe - Find
forEach { println(it) }patternsorg.openrewrite.kotlin.bestpractices.FindForEachPrintln$KtRecipe - Find
xs.toList().forEach { … }patternsorg.openrewrite.kotlin.bestpractices.FindToListBeforeForEach$KtRecipe - Find
mutableListOf<T>().also { it.add(x) }patternsorg.openrewrite.kotlin.bestpractices.FindMutableListAlsoAdd$KtRecipe - Find
mutableMapOf<K,V>().also { it.put(...) }patternsorg.openrewrite.kotlin.bestpractices.FindMutableMapAlsoPut$KtRecipe - Find
mutableSetOf<T>().also { it.add(x) }patternsorg.openrewrite.kotlin.bestpractices.FindMutableSetAlsoAdd$KtRecipe - Find
xs.forEach { ys.add(it) }patternsorg.openrewrite.kotlin.bestpractices.FindForEachAddCandidate$KtRecipe
Data tables
Structured output this recipe can produce.
- Source files that had resultsSource files that were modified by the recipe run.
org.openrewrite.table.SourcesFileResults - Source files that had search resultsSearch results that were found during the recipe run.
org.openrewrite.table.SearchResults - Source files that errored on a recipeThe details of all errors produced by a recipe run.
org.openrewrite.table.SourcesFileErrors - Recipe performanceStatistics used in analyzing the performance of recipes.
org.openrewrite.table.RecipeRunStats