Find Boolean-conditional smells
Recipe ID
org.openrewrite.kotlin.bestpractices.FindBooleanConditionalSmells$KtRecipeArtifactio.moderne.recipe:recipes-kotlinif (x) true else false, its inverse, !x.isEmpty() / !x.isBlank() family negations, if (x == null) null else x.foo(), if (x != null) x.foo() patterns, and if (return …) else … early-return ladders — each is the long form of a single Kotlin operator or method.
Composite recipeProprietary
Add to your build
Get a download tokenThis recipe is Moderne licensed, so the token must belong to a Moderne customer. It replaces YOUR_DOWNLOAD_TOKEN below.
~/.gradle/gradle.properties
codeGenomeUsername=you@example.com
codeGenomeToken=YOUR_DOWNLOAD_TOKEN
build.gradle.kts
plugins {
id("org.openrewrite.rewrite") version("latest.release")
}
rewrite {
activeRecipe("org.openrewrite.kotlin.bestpractices.FindBooleanConditionalSmells$KtRecipe")
}
repositories {
mavenCentral()
maven {
url = uri("https://artifacts.codegenomeproject.org/maven")
credentials {
username = providers.gradleProperty("codeGenomeUsername").get()
password = providers.gradleProperty("codeGenomeToken").get()
}
}
}
dependencies {
rewrite("io.moderne.recipe:recipes-kotlin:0.5.0")
}
Then run
./gradlew rewriteRunUsage
This recipe has no required configuration options. You’ll need the Moderne CLI configured before running the command below.
mod run . --recipe org.openrewrite.kotlin.bestpractices.FindBooleanConditionalSmells$KtRecipeIf the recipe isn’t available locally, install it with:
mod config recipes jar install io.moderne.recipe:recipes-kotlin:RELEASEDefinition
This recipe runs the following recipes in order.
- Find
if (x) true else falsepatternsorg.openrewrite.kotlin.bestpractices.FindIfReturnTrueElseFalse$KtRecipe - Find
if (x) false else truepatternsorg.openrewrite.kotlin.bestpractices.FindIfReturnFalseElseTrue$KtRecipe - Find
if (x == null) null else x.foo()patternsorg.openrewrite.kotlin.bestpractices.FindIfNullElseExpression$KtRecipe - Find
if (x != null) x.foo()patternsorg.openrewrite.kotlin.bestpractices.FindLetForNotNullCheck$KtRecipe - Find
!x.isEmpty()callsorg.openrewrite.kotlin.bestpractices.FindNegatedIsEmpty$KtRecipe - Find
!x.isNotEmpty()callsorg.openrewrite.kotlin.bestpractices.FindNegatedIsNotEmpty$KtRecipe - Find
!x.isBlank()callsorg.openrewrite.kotlin.bestpractices.FindNegatedIsBlank$KtRecipe - Find
!x.isNotBlank()callsorg.openrewrite.kotlin.bestpractices.FindNegatedIsNotBlank$KtRecipe - Find
x.isNotEmpty()onStringwhereisNotBlank()might be wantedorg.openrewrite.kotlin.bestpractices.FindIsNotEmptyOnString$KtRecipe - Find
if (x) { return … } else { … }patternsorg.openrewrite.kotlin.bestpractices.FindElseAfterReturn$KtRecipe
Data tables
Structured output this recipe can produce.
- Source files that had resultsSource files that were modified by the recipe run.
org.openrewrite.table.SourcesFileResults - Source files that had search resultsSearch results that were found during the recipe run.
org.openrewrite.table.SearchResults - Source files that errored on a recipeThe details of all errors produced by a recipe run.
org.openrewrite.table.SourcesFileErrors - Recipe performanceStatistics used in analyzing the performance of recipes.
org.openrewrite.table.RecipeRunStats