Find Boolean-conditional smells
Recipe ID
org.openrewrite.kotlin.bestpractices.FindBooleanConditionalSmells$KtRecipeArtifact
io.moderne.recipe:recipes-kotlinif (x) true else false, its inverse, !x.isEmpty() / !x.isBlank() family negations, if (x == null) null else x.foo(), if (x != null) x.foo() patterns, and if (return …) else … early-return ladders — each is the long form of a single Kotlin operator or method.
Usage
This recipe has no required configuration options. You’ll need the Moderne CLI configured before running the command below.
mod run . --recipe org.openrewrite.kotlin.bestpractices.FindBooleanConditionalSmells$KtRecipeIf the recipe isn’t available locally, install it with:
mod config recipes jar install io.moderne.recipe:recipes-kotlin:0.2.0Definition
This recipe runs the following recipes in order.
- Find
if (x) true else falsepatternsorg.openrewrite.kotlin.bestpractices.FindIfReturnTrueElseFalse$KtRecipe - Find
if (x) false else truepatternsorg.openrewrite.kotlin.bestpractices.FindIfReturnFalseElseTrue$KtRecipe - Find
if (x == null) null else x.foo()patternsorg.openrewrite.kotlin.bestpractices.FindIfNullElseExpression$KtRecipe - Find
if (x != null) x.foo()patternsorg.openrewrite.kotlin.bestpractices.FindLetForNotNullCheck$KtRecipe - Find
!x.isEmpty()callsorg.openrewrite.kotlin.bestpractices.FindNegatedIsEmpty$KtRecipe - Find
!x.isNotEmpty()callsorg.openrewrite.kotlin.bestpractices.FindNegatedIsNotEmpty$KtRecipe - Find
!x.isBlank()callsorg.openrewrite.kotlin.bestpractices.FindNegatedIsBlank$KtRecipe - Find
!x.isNotBlank()callsorg.openrewrite.kotlin.bestpractices.FindNegatedIsNotBlank$KtRecipe - Find
x.isNotEmpty()onStringwhereisNotBlank()might be wantedorg.openrewrite.kotlin.bestpractices.FindIsNotEmptyOnString$KtRecipe - Find
if (x) { return … } else { … }patternsorg.openrewrite.kotlin.bestpractices.FindElseAfterReturn$KtRecipe
Data tables
Structured output this recipe can produce.
- Source files that had resultsSource files that were modified by the recipe run.
org.openrewrite.table.SourcesFileResults - Source files that had search resultsSearch results that were found during the recipe run.
org.openrewrite.table.SearchResults - Source files that errored on a recipeThe details of all errors produced by a recipe run.
org.openrewrite.table.SourcesFileErrors - Recipe performanceStatistics used in analyzing the performance of recipes.
org.openrewrite.table.RecipeRunStats